[AVFoundation] Update framework for Xcode 12 beta 4. #9354

mandel-macaque · 2020-08-12T17:50:28Z

No description provided.

mandel-macaque · 2020-08-12T18:02:33Z

src/avfoundation.cs

+	interface AVAssetSegmentTrackReport {
+		[Export ("trackID")]
+		int TrackId { get; }
+


BindAs AVMediaTypes https://developer.apple.com/documentation/avfoundation/avassetsegmenttrackreport/3546580-mediatype?language=objc

src/avfoundation.cs

spouliot · 2020-08-12T17:55:40Z

src/AVFoundation/Enums.cs

+	[Native]
+	[NoTV, NoWatch, Mac (11, 0), NoiOS]
+	public enum AVAudioRoutingArbitrationCategory : long {
+		back = 0,


spouliot · 2020-08-12T17:56:28Z

src/AVFoundation/Enums.cs

+	public enum AVAudioRoutingArbitrationCategory : long {
+		back = 0,
+		AndRecord = 1,
+		AndRecordVoice = 2,


weird names... are they flags ?

missing Play prefix, makes sense now
https://developer.apple.com/documentation/avfoundation/avaudioroutingarbitrationcategory?changes=latest_minor%20r_8&language=objc

spouliot · 2020-08-12T18:00:53Z

src/avfoundation.cs

+
+		[NoWatch, NoTV, NoMac, iOS (14, 0)]
+		[Field ("AVAudioSessionPolarPatternStereo")]
+		NSString PolarPatternStereo { get; }


There are other (older) members defined for AVAudioSessionPolarPattern and this one should go with them

https://developer.apple.com/documentation/avfoundation/avaudiosessionpolarpattern

You mean move it to the same location in the file?

it should be along other AVAudioSessionPolarPattern* fields which, sadly, are old enough that a smart enum was not used for them :(

We wont forget now: #9356 will done once xcode12 is done.

spouliot · 2020-08-12T18:04:05Z

src/avfoundation.cs

+		[TV (14, 0), NoWatch, Mac (11, 0), iOS (14, 0)]
+		[Export ("outputFileTypeProfile")]
+		[NullAllowed]
+		string OutputFileTypeProfile { get; set; }


In ObjC that's AVFileTypeProfile (a NSString subclass) which you have defined before
Better bind this as a smart enum (or an NSString) but not a normal string

spouliot · 2020-08-12T18:05:07Z

src/avfoundation.cs

+
+		[TV (14, 0), NoWatch, Mac (11, 0), iOS (14, 0)]
+		[Export ("supportsHDRSourceFrames")]
+		bool SupportsHDRSourceFrames { get; }


spouliot · 2020-08-12T18:07:44Z

src/avfoundation.cs

@@ -13140,7 +13375,7 @@ interface AVContentKeySession {
 	}

 	[Static][Internal]
-	[NoWatch, NoTV, Mac (10,15), iOS (12,2)]
+	[Watch (2,0), NoTV, Mac (10,15), iOS (12,2)]


hmm... I don't think AVFoundation was available in 2.0

https://developer.apple.com/documentation/avfoundation?language=objc suggest it was in 3.0
In about better use the current SDK as it was likely not very useful before now

monojenkins · 2020-08-12T18:10:21Z

Build failure
❌ Build failed or was aborted

✅ Build succeeded
✅ API Diff (from stable)

whitneyschmidt

Mostly tiny formatting consistency nits 🙈

src/AVFoundation/Enums.cs

src/avfoundation.cs

whitneyschmidt · 2020-08-12T19:06:09Z

src/avfoundation.cs

 		[NullAllowed, Export ("error")]
 		NSError Error { get; }

-		[NoWatch]
+		[Watch (7, 0)]
 		[NullAllowed, Export ("identifier")]
 		NSObject Identifier { get; }


Is it possible to do any better than an NSObject for Identifier?

Header:

/* @property identifier @abstract Container- and protocol-specific identifier for the content key. @discussion In order to use a key with an HTTP Live Streaming AVURLAsset, the identifier must be an NSURL that matches a key URI in the Media Playlist. */ @property (readonly, nullable) id identifier;

Mope, identifiers are just an NSObject, we do not care about it. It is used to later retrieve it. This is 'common' in other APIs.

monojenkins · 2020-08-12T20:04:58Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
⚠️ API Diff (from PR only) (🔥 breaking changes 🔥)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

1 tests failed, 75 tests passed.

Failed tests

introspection/watchOS 32-bits - simulator/Debug (watchOS 3.2): Failed

Co-authored-by: Whitney Schmidt <whschm@microsoft.com>

monojenkins · 2020-08-12T21:55:25Z

Build failure
❌ Build failed or was aborted

✅ Build succeeded
✅ API Diff (from stable)

monojenkins · 2020-08-12T22:10:20Z

Build failure
❌ Build failed or was aborted

✅ Build succeeded
✅ API Diff (from stable)

monojenkins · 2020-08-13T00:36:31Z

Build success
✅ Build succeeded
✅ API Diff (from stable)
⚠️ API Diff (from PR only) (🔥 breaking changes 🔥)
ℹ️ Generator Diff (please review changes)
✅ Test run succeeded

src/avfoundation.cs

rolfbjarne · 2020-08-13T07:20:41Z

src/avfoundation.cs

+
+		[TV (14, 0), NoWatch, Mac (11, 0), iOS (14, 0)]
+		[NullAllowed, Export ("delegate", ArgumentSemantic.Weak)]
+		NSObject WriterWeakDelegate { get; set; }


Why Writer*Delegate instead of just *Delegate? There doesn't seem to be a Delegate property already.

This comes from a category. I fear that an other category might be added with a Delegate, which could mean that we will have the Deprecated XAMCORE_4 dance. Since it is a category, it might happen. Unless you see this not being possible, I prefer to add the Writer prefix.

Not that I recall, I think we can leave just the Delegate name here, it makes sense AVAssetWriter is the class name and AVAssetWriterDelegate is its delegate.

My vote is to just use Delegate and WeakDelegate as managed names.

src/avfoundation.cs

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

…e/xamarin-macios into avfoundation-xcode14-beta4

monojenkins · 2020-08-13T16:00:11Z

Build failure
❌ Build failed or was aborted

monojenkins · 2020-08-13T17:51:56Z

Build failure
❌ Build failed or was aborted

✅ Build succeeded
✅ API Diff (from stable)
⚠️ API Diff (from PR only) (🔥 breaking changes 🔥)
ℹ️ Generator Diff (please review changes)

monojenkins · 2020-08-13T18:07:55Z

Build failure
❌ Build failed or was aborted

🔥 Build failed 🔥

monojenkins · 2020-08-13T20:46:40Z

Build success
✅ Build succeeded
✅ API Diff (from stable)
⚠️ API Diff (from PR only) (🔥 breaking changes 🔥)
ℹ️ Generator Diff (please review changes)
✅ Test run succeeded

[AVFoundation] Update framework for Xcode 12 beta 4.

fcdb5ba

mandel-macaque added the note-highlight Worth calling out specifically in release notes label Aug 12, 2020

mandel-macaque requested review from dalexsoto and spouliot as code owners August 12, 2020 17:50

mandel-macaque commented Aug 12, 2020

View reviewed changes

src/avfoundation.cs Outdated Show resolved Hide resolved

Update src/avfoundation.cs

24f80df

spouliot suggested changes Aug 12, 2020

View reviewed changes

whitneyschmidt approved these changes Aug 12, 2020

View reviewed changes

mandel-macaque and others added 2 commits August 12, 2020 17:29

Apply suggestions from code review

b29e8a6

Co-authored-by: Whitney Schmidt <whschm@microsoft.com>

Apply suggestions from code review

2fda2a1

Co-authored-by: Whitney Schmidt <whschm@microsoft.com>

Address reviews.

393f406

dalexsoto approved these changes Aug 12, 2020

View reviewed changes

spouliot suggested changes Aug 13, 2020

View reviewed changes

src/avfoundation.cs Show resolved Hide resolved

rolfbjarne requested changes Aug 13, 2020

View reviewed changes

mandel-macaque and others added 3 commits August 13, 2020 11:52

Apply suggestions from code review

0857b09

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>

Address reviews.

52ef584

Merge branch 'avfoundation-xcode14-beta4' of github.com:mandel-macaqu…

f980730

…e/xamarin-macios into avfoundation-xcode14-beta4

rolfbjarne approved these changes Aug 13, 2020

View reviewed changes

Address reviews.

4aa985a

dalexsoto approved these changes Aug 13, 2020

View reviewed changes

spouliot approved these changes Aug 13, 2020

View reviewed changes

Fix compilation issue.

bc1a7c7

mandel-macaque merged commit 1be4b57 into xamarin:xcode12 Aug 13, 2020

mandel-macaque deleted the avfoundation-xcode14-beta4 branch August 13, 2020 21:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AVFoundation] Update framework for Xcode 12 beta 4. #9354

[AVFoundation] Update framework for Xcode 12 beta 4. #9354

mandel-macaque commented Aug 12, 2020

mandel-macaque Aug 12, 2020 •

edited

Loading

spouliot Aug 12, 2020

spouliot Aug 12, 2020

spouliot Aug 12, 2020

spouliot Aug 12, 2020

mandel-macaque Aug 12, 2020

spouliot Aug 12, 2020

mandel-macaque Aug 12, 2020

spouliot Aug 12, 2020

spouliot Aug 12, 2020

spouliot Aug 12, 2020

monojenkins commented Aug 12, 2020

whitneyschmidt left a comment

whitneyschmidt Aug 12, 2020

mandel-macaque Aug 12, 2020

monojenkins commented Aug 12, 2020

Failed tests

monojenkins commented Aug 12, 2020

monojenkins commented Aug 12, 2020

monojenkins commented Aug 13, 2020

rolfbjarne Aug 13, 2020 •

edited

Loading

mandel-macaque Aug 13, 2020

dalexsoto Aug 13, 2020

monojenkins commented Aug 13, 2020

monojenkins commented Aug 13, 2020

monojenkins commented Aug 13, 2020

monojenkins commented Aug 13, 2020

[AVFoundation] Update framework for Xcode 12 beta 4. #9354

[AVFoundation] Update framework for Xcode 12 beta 4. #9354

Conversation

mandel-macaque commented Aug 12, 2020

mandel-macaque Aug 12, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

monojenkins commented Aug 12, 2020

whitneyschmidt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

monojenkins commented Aug 12, 2020

Test results

Failed tests

monojenkins commented Aug 12, 2020

monojenkins commented Aug 12, 2020

monojenkins commented Aug 13, 2020

rolfbjarne Aug 13, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

monojenkins commented Aug 13, 2020

monojenkins commented Aug 13, 2020

monojenkins commented Aug 13, 2020

monojenkins commented Aug 13, 2020

mandel-macaque Aug 12, 2020 •

edited

Loading

rolfbjarne Aug 13, 2020 •

edited

Loading