Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ScreenTime] New framework for Xcode 12 up to beta 4. #9379

Merged
merged 3 commits into from
Aug 15, 2020
Merged

[ScreenTime] New framework for Xcode 12 up to beta 4. #9379

merged 3 commits into from
Aug 15, 2020

Conversation

mandel-macaque
Copy link
Member

No description provided.

mandel-macaque
mandel-macaque commented Aug 14, 2020
View reviewed changes
src/screentime.cs Outdated Show resolved Hide resolved
spouliot
spouliot approved these changes Aug 14, 2020
View reviewed changes
src/screentime.cs Show resolved Hide resolved
src/screentime.cs Show resolved Hide resolved
dalexsoto
dalexsoto approved these changes Aug 14, 2020
View reviewed changes
Copy link
Member

@dalexsoto dalexsoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 After adding the suggested DisableDefaultCtor

@monojenkins
Copy link
Collaborator

Build failure
❌ Build failed or was aborted

@monojenkins
Copy link
Collaborator

Build failure
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

1 tests failed, 78 tests passed.

Failed tests

  • MTouch tests/NUnit: Failed (Execution failed with exit code 5)

@mandel-macaque
Copy link
Member Author

Failure is unrelated: https://github.com/xamarin/maccore/issues/1028

@mandel-macaque mandel-macaque merged commit 09fa826 into xamarin:xcode12 Aug 15, 2020
@mandel-macaque mandel-macaque deleted the screentime-xcode12-beta4 branch August 15, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@spouliot spouliot spouliot approved these changes

@whitneyschmidt whitneyschmidt whitneyschmidt approved these changes

@chamons chamons Awaiting requested review from chamons

@rolfbjarne rolfbjarne Awaiting requested review from rolfbjarne rolfbjarne is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mandel-macaque @monojenkins @dalexsoto @spouliot @whitneyschmidt