-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CoreTelephony] Update framework for Xcode 12. #9398
[CoreTelephony] Update framework for Xcode 12. #9398
Conversation
Framework has been deprecated for CallKit, selector have been removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
src/CoreTelephony/CoreTelephony.cs
Outdated
@@ -42,6 +42,7 @@ public enum CTErrorDomain { | |||
NoError = 0, Posix = 1, Mach = 2 | |||
} | |||
|
|||
[Obsolete ("Use the 'CallKit' API instead.")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we use [Obsolete]
for binding mistakes.
[Obsoleted]
(with d
) or [Deprecated]
along with a OS name / version number should be used.
E.g. just above there's some
[Deprecated (PlatformName.iOS, 10, 0, message : "Use CallKit")]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding more letters == more typos. 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worry, I'm here to make fun of find them 😺
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After Sebastien's comment is fixed.
Build success |
Build failure |
Build failure Test results1 tests failed, 75 tests passed.Failed tests
|
Build failure Test results3 tests failed, 73 tests passed.Failed tests
|
Failures are related to https://github.com/xamarin/maccore/issues/2289 |
Framework has been deprecated for CallKit, selector have been removed.