Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CoreTelephony] Update framework for Xcode 12. #9398

Merged

Conversation

mandel-macaque
Copy link
Member

Framework has been deprecated for CallKit, selector have been removed.

Framework has been deprecated for CallKit, selector have been removed.
Copy link
Contributor

@whitneyschmidt whitneyschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@@ -42,6 +42,7 @@ public enum CTErrorDomain {
NoError = 0, Posix = 1, Mach = 2
}

[Obsolete ("Use the 'CallKit' API instead.")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we use [Obsolete] for binding mistakes.
[Obsoleted] (with d) or [Deprecated] along with a OS name / version number should be used.

E.g. just above there's some

[Deprecated (PlatformName.iOS, 10, 0, message : "Use CallKit")]

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding more letters == more typos. 😅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worry, I'm here to make fun of find them 😺

Copy link
Member

@dalexsoto dalexsoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After Sebastien's comment is fixed.

@monojenkins
Copy link
Collaborator

Build success
Build succeeded
API Diff (from stable)
API Diff (from PR only) (no change)
Generator Diff (no change)
Test run succeeded

@monojenkins
Copy link
Collaborator

Build failure
Build failed or was aborted

@monojenkins
Copy link
Collaborator

Build failure
Build succeeded
API Diff (from stable)
API Diff (from PR only) (no change)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

1 tests failed, 75 tests passed.

Failed tests

  • Xtro/Mac: Failed (Test run failed.)

@monojenkins
Copy link
Collaborator

Build failure
Build succeeded
API Diff (from stable)
API Diff (from PR only) (no change)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

3 tests failed, 73 tests passed.

Failed tests

  • apitest/Mac Modern/Debug: BuildFailure
  • introspection/Mac Modern/Debug: BuildFailure
  • apitest/Mac Full/Debug: BuildFailure

@mandel-macaque
Copy link
Member Author

Failures are related to https://github.com/xamarin/maccore/issues/2289

@mandel-macaque mandel-macaque merged commit d168637 into xamarin:xcode12 Aug 19, 2020
@mandel-macaque mandel-macaque deleted the coretelephony-xcode12-beta4 branch August 19, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants