[CoreData] Update framework for Xcode 12 beta 4. #9405
Conversation
src/coredata.cs
Outdated
| [Watch (7,0), TV (14,0), Mac (11,0), iOS (14,0)] | ||
| [Static] | ||
| [Export ("batchInsertRequestWithEntityName:dictionaryHandler:")] | ||
| NSBatchInsertRequest BatchInsertRequest (string entityName, NSBatchInsertRequestDictionaryHandler handler); |
There was a problem hiding this comment.
no verb, Insert is not a verb here since it return a type of that name,
-> CreateBatchInsertRequest
src/coredata.cs
Outdated
| [Watch (7,0), TV (14,0), Mac (11,0), iOS (14,0)] | ||
| [Static] | ||
| [Export ("batchInsertRequestWithEntityName:managedObjectHandler:")] | ||
| NSBatchInsertRequest BatchInsertRequest (string entityName, NSBatchInsertRequestManagedObjectHandler handler); |
src/coredata.cs
Outdated
|
|
||
| [Static] | ||
| [Export ("fetchEventsAfterDate:")] | ||
| NSPersistentCloudKitContainerEventRequest FetchEvents (NSDate date); |
There was a problem hiding this comment.
Minimally the parameter name should be afterDate, otherwise that information is lost
but I think it might be better to have FetchEventsAfter (NSDate date) since ...beforeDate: could be added later and cause confusion
src/coredata.cs
Outdated
|
|
||
| [Static] | ||
| [Export ("fetchEventsAfterEvent:")] | ||
| NSPersistentCloudKitContainerEventRequest FetchEvents ([NullAllowed] NSPersistentCloudKitContainerEvent @event); |
There was a problem hiding this comment.
Is after the next commit
|
Build failure ✅ Build succeeded |
Co-authored-by: Whitney Schmidt <whschm@microsoft.com>
|
Build failure ✅ Build succeeded |
|
Build success |
| [Watch (7,0), TV (14,0), Mac (11,0), iOS (14,0)] | ||
| interface NSManagedObjectsIdsChangedEventArgs { | ||
| [Export ("NSDeletedObjectIDsKey")] | ||
| NSSet DeletedObjectIds { get; } |
There was a problem hiding this comment.
@mandel-macaque Why doesn't this one get a Key suffix when all the other members here do?
| @@ -2492,6 +2520,13 @@ interface NSConstraintConflict | |||
| NSDictionary[] ConflictingSnapshots { get; } | |||
| } | |||
|
|
|||
| #if XAMCORE_4_0 | |||
| delegate bool NSBatchInsertRequestDictionaryHandler (NSMutableDictionary<NSString, NSObject> dictionary); | |||
There was a problem hiding this comment.
Why couldn't this version be used right now?
No description provided.