-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VideoToolBox] Update framework to xcode 12 beta 5. #9457
[VideoToolBox] Update framework to xcode 12 beta 5. #9457
Conversation
b65de8c
to
e5376b8
Compare
Build failure 🔥 Build failed 🔥 |
Build success |
src/VideoToolbox/VTDefs.cs
Outdated
|
||
[Watch (7, 0), TV (14, 0), Mac (11, 0), iOS (14, 0)] | ||
public enum HdrMetadataInsertionMode { | ||
[Watch (7, 0), TV (14, 0), Mac (11, 0), iOS (14, 0)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed, it's the same as the type itself
[NoWatch, NoTV, NoiOS, Mac (11,0)] | ||
public static void RegisterSupplementalVideoDecoder (CMVideoCodecType codecType) | ||
=> VTRegisterSupplementalVideoDecoderIfAvailable ((uint) codecType); | ||
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing unit test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After comments are addressed
Build success |
No description provided.