Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VideoToolBox] Update framework to xcode 12 beta 5. #9457

Merged

Conversation

mandel-macaque
Copy link
Member

No description provided.

@monojenkins
Copy link
Collaborator

Build failure
Build failed or was aborted

🔥 Build failed 🔥

@monojenkins
Copy link
Collaborator

Build success
Build succeeded
API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
Test run succeeded


[Watch (7, 0), TV (14, 0), Mac (11, 0), iOS (14, 0)]
public enum HdrMetadataInsertionMode {
[Watch (7, 0), TV (14, 0), Mac (11, 0), iOS (14, 0)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed, it's the same as the type itself

[NoWatch, NoTV, NoiOS, Mac (11,0)]
public static void RegisterSupplementalVideoDecoder (CMVideoCodecType codecType)
=> VTRegisterSupplementalVideoDecoderIfAvailable ((uint) codecType);
#endif
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing unit test

Copy link
Member

@dalexsoto dalexsoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After comments are addressed

@monojenkins
Copy link
Collaborator

Build success
Build succeeded
API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
Test run succeeded

@mandel-macaque mandel-macaque merged commit 010a71c into xamarin:xcode12 Aug 24, 2020
@mandel-macaque mandel-macaque deleted the videotoolbox-xcode12-beta5 branch August 24, 2020 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants