[msbuild] Fix AdditionalAppExtensions entitlement logic

[chamons]

• Fixes [Xcode 12] AdditionalAppExtensions entitlements path resolution add space and newline characters causing codesign to fail #9458
• Defining the variable over multiple lines changes output to include incorrect newline
• Auto tests did not catch, as they don't sign on bots due to infrastructure issues.
• Was refactored after manual tests and not retested

[dalexsoto]

Oh wow this is... well... I'll just 🙊

[monojenkins]

Build failure
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
🔥 Test run failed 🔥

Test results

1 tests failed, 76 tests passed.

Failed tests

• MTouch tests/NUnit: Failed (Execution failed with exit code 5)

[chamons]

Failures are all networking:

17:59:26.2408920 1) Error : Xamarin.MTouch.HttpClientHandler("CFNetworkHandler","CFNetworkHandler")
17:59:26.2409350 Xamarin.Tests.TestExecutionException : Execution failed (exit code: 1) for 'mono /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/tests/xharness/xharness.exe --run /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/tests/mtouch/bin/Debug/tmp-test-dir/Xamarin.MTouch.RunUnitTest/testapp.csproj --target ios-simulator-64 --sdkroot /Applications/Xcode_12.0.0-beta5.app/Contents/Developer --logdirectory /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/tests/mtouch/bin/Debug/tmp-test-dir/Xamarin.MTouch.RunUnitTest/log.txt --configuration Debug'
17:59:26.2409550   at Xamarin.Tests.ExecutionHelper.Execute (System.String fileName, System.String arguments, System.Boolean throwOnError, System.Collections.Generic.Dictionary`2[TKey,TValue] environmentVariables, System.Boolean hide_output, System.Nullable`1[T] timeout) [0x00070] in <1b53e5c0c29b4df282039c569d8e4e35>:0 
17:59:26.2409720   at Xamarin.Tests.ExecutionHelper.Execute (System.String fileName, System.Collections.Generic.IList`1[T] arguments, System.Boolean throwOnError, System.Collections.Generic.Dictionary`2[TKey,TValue] environmentVariables, System.Boolean hide_output, System.Nullable`1[T] timeout) [0x00008] in <1b53e5c0c29b4df282039c569d8e4e35>:0 
17:59:26.2410140   at Xamarin.MTouch.RunUnitTest (Xamarin.Tests.Profile profile, System.String code, System.String csproj_configuration, System.String[] csproj_references, System.String configuration, System.String platform, System.Boolean clean_simulator) [0x001b9] in <1b53e5c0c29b4df282039c569d8e4e35>:0 
17:59:26.2410340   at Xamarin.MTouch.HttpClientHandler (System.String mtouchHandler, System.String expectedHandler) [0x0002d] in <1b53e5c0c29b4df282039c569d8e4e35>:0 
17:59:26.2410500   at (wrapper managed-to-native) System.Reflection.RuntimeMethodInfo.InternalInvoke(System.Reflection.RuntimeMethodInfo,object,object[],System.Exception&)
17:59:26.2410650   at System.Reflection.RuntimeMethodInfo.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x0006a] in <dd436d8b1aa7421eb3bcf48b995163c4>:0 
17:59:26.2410810 
17:59:26.2410970 2) Error : Xamarin.MTouch.HttpClientHandler("NSUrlSessionHandler","NSUrlSessionHandler")
17:59:26.2411400 Xamarin.Tests.TestExecutionException : Execution failed (exit code: 1) for 'mono /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/tests/xharness/xharness.exe --run /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/tests/mtouch/bin/Debug/tmp-test-dir/Xamarin.MTouch.RunUnitTest115/testapp.csproj --target ios-simulator-64 --sdkroot /Applications/Xcode_12.0.0-beta5.app/Contents/Developer --logdirectory /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/tests/mtouch/bin/Debug/tmp-test-dir/Xamarin.MTouch.RunUnitTest115/log.txt --configuration Debug'
17:59:26.2411600   at Xamarin.Tests.ExecutionHelper.Execute (System.String fileName, System.String arguments, System.Boolean throwOnError, System.Collections.Generic.Dictionary`2[TKey,TValue] environmentVariables, System.Boolean hide_output, System.Nullable`1[T] timeout) [0x00070] in <1b53e5c0c29b4df282039c569d8e4e35>:0 
17:59:26.2411780   at Xamarin.Tests.ExecutionHelper.Execute (System.String fileName, System.Collections.Generic.IList`1[T] arguments, System.Boolean throwOnError, System.Collections.Generic.Dictionary`2[TKey,TValue] environmentVariables, System.Boolean hide_output, System.Nullable`1[T] timeout) [0x00008] in <1b53e5c0c29b4df282039c569d8e4e35>:0 
17:59:26.2412210   at Xamarin.MTouch.RunUnitTest (Xamarin.Tests.Profile profile, System.String code, System.String csproj_configuration, System.String[] csproj_references, System.String configuration, System.String platform, System.Boolean clean_simulator) [0x001b9] in <1b53e5c0c29b4df282039c569d8e4e35>:0 
17:59:26.2412410   at Xamarin.MTouch.HttpClientHandler (System.String mtouchHandler, System.String expectedHandler) [0x0002d] in <1b53e5c0c29b4df282039c569d8e4e35>:0 
17:59:26.2412570   at (wrapper managed-to-native) System.Reflection.RuntimeMethodInfo.InternalInvoke(System.Reflection.RuntimeMethodInfo,object,object[],System.Exception&)
17:59:26.2412730   at System.Reflection.RuntimeMethodInfo.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x0006a] in <dd436d8b1aa7421eb3bcf48b995163c4>:0 
17:59:26.2412880 
17:59:26.2413040 3) Error : Xamarin.MTouch.HttpClientHandler("HttpClientHandler","HttpClientHandler")
17:59:26.2413460 Xamarin.Tests.TestExecutionException : Execution failed (exit code: 1) for 'mono /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/tests/xharness/xharness.exe --run /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/tests/mtouch/bin/Debug/tmp-test-dir/Xamarin.MTouch.RunUnitTest116/testapp.csproj --target ios-simulator-64 --sdkroot /Applications/Xcode_12.0.0-beta5.app/Contents/Developer --logdirectory /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/tests/mtouch/bin/Debug/tmp-test-dir/Xamarin.MTouch.RunUnitTest116/log.txt --configuration Debug'
17:59:26.2413660   at Xamarin.Tests.ExecutionHelper.Execute (System.String fileName, System.String arguments, System.Boolean throwOnError, System.Collections.Generic.Dictionary`2[TKey,TValue] environmentVariables, System.Boolean hide_output, System.Nullable`1[T] timeout) [0x00070] in <1b53e5c0c29b4df282039c569d8e4e35>:0 
17:59:26.2413840   at Xamarin.Tests.ExecutionHelper.Execute (System.String fileName, System.Collections.Generic.IList`1[T] arguments, System.Boolean throwOnError, System.Collections.Generic.Dictionary`2[TKey,TValue] environmentVariables, System.Boolean hide_output, System.Nullable`1[T] timeout) [0x00008] in <1b53e5c0c29b4df282039c569d8e4e35>:0 
17:59:26.2414260   at Xamarin.MTouch.RunUnitTest (Xamarin.Tests.Profile profile, System.String code, System.String csproj_configuration, System.String[] csproj_references, System.String configuration, System.String platform, System.Boolean clean_simulator) [0x001b9] in <1b53e5c0c29b4df282039c569d8e4e35>:0 
17:59:26.2414450   at Xamarin.MTouch.HttpClientHandler (System.String mtouchHandler, System.String expectedHandler) [0x0002d] in <1b53e5c0c29b4df282039c569d8e4e35>:0 
17:59:26.2414620   at (wrapper managed-to-native) System.Reflection.RuntimeMethodInfo.InternalInvoke(System.Reflection.RuntimeMethodInfo,object,object[],System.Exception&)
17:59:26.2414780   at System.Reflection.RuntimeMethodInfo.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x0006a] in <dd436d8b1aa7421eb3bcf48b995163c4>:0 
17:59:26.2414930 
17:59:26.2415090 4) Error : Xamarin.MTouch.HttpClientHandler(null,"NSUrlSessionHandler")
17:59:26.2415500 Xamarin.Tests.TestExecutionException : Execution failed (exit code: 1) for 'mono /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/tests/xharness/xharness.exe --run /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/tests/mtouch/bin/Debug/tmp-test-dir/Xamarin.MTouch.RunUnitTest117/testapp.csproj --target ios-simulator-64 --sdkroot /Applications/Xcode_12.0.0-beta5.app/Contents/Developer --logdirectory /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/tests/mtouch/bin/Debug/tmp-test-dir/Xamarin.MTouch.RunUnitTest117/log.txt --configuration Debug'
17:59:26.2415710   at Xamarin.Tests.ExecutionHelper.Execute (System.String fileName, System.String arguments, System.Boolean throwOnError, System.Collections.Generic.Dictionary`2[TKey,TValue] environmentVariables, System.Boolean hide_output, System.Nullable`1[T] timeout) [0x00070] in <1b53e5c0c29b4df282039c569d8e4e35>:0 
17:59:26.2416160   at Xamarin.Tests.ExecutionHelper.Execute (System.String fileName, System.Collections.Generic.IList`1[T] arguments, System.Boolean throwOnError, System.Collections.Generic.Dictionary`2[TKey,TValue] environmentVariables, System.Boolean hide_output, System.Nullable`1[T] timeout) [0x00008] in <1b53e5c0c29b4df282039c569d8e4e35>:0 
17:59:26.2416360   at Xamarin.MTouch.RunUnitTest (Xamarin.Tests.Profile profile, System.String code, System.String csproj_configuration, System.String[] csproj_references, System.String configuration, System.String platform, System.Boolean clean_simulator) [0x001b9] in <1b53e5c0c29b4df282039c569d8e4e35>:0 
17:59:26.2416530   at Xamarin.MTouch.HttpClientHandler (System.String mtouchHandler, System.String expectedHandler) [0x0002d] in <1b53e5c0c29b4df282039c569d8e4e35>:0 
17:59:26.2416680   at (wrapper managed-to-native) System.Reflection.RuntimeMethodInfo.InternalInvoke(System.Reflection.RuntimeMethodInfo,object,object[],System.Exception&)
17:59:26.2416850   at System.Reflection.RuntimeMethodInfo.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x0006a] in <dd436d8b1aa7421eb3bcf48b995163c4>:0 
17:59:26.2417000 
17:59:26.2417410 5) Error : Xamarin.MTouch.HttpClientHandler("","NSUrlSessionHandler")
17:59:26.2417600 Xamarin.Tests.TestExecutionException : Execution failed (exit code: 1) for 'mono /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/tests/xharness/xharness.exe --run /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/tests/mtouch/bin/Debug/tmp-test-dir/Xamarin.MTouch.RunUnitTest118/testapp.csproj --target ios-simulator-64 --sdkroot /Applications/Xcode_12.0.0-beta5.app/Contents/Developer --logdirectory /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/tests/mtouch/bin/Debug/tmp-test-dir/Xamarin.MTouch.RunUnitTest118/log.txt --configuration Debug'
17:59:26.2417780   at Xamarin.Tests.ExecutionHelper.Execute (System.String fileName, System.String arguments, System.Boolean throwOnError, System.Collections.Generic.Dictionary`2[TKey,TValue] environmentVariables, System.Boolean hide_output, System.Nullable`1[T] timeout) [0x00070] in <1b53e5c0c29b4df282039c569d8e4e35>:0 
17:59:26.2418200   at Xamarin.Tests.ExecutionHelper.Execute (System.String fileName, System.Collections.Generic.IList`1[T] arguments, System.Boolean throwOnError, System.Collections.Generic.Dictionary`2[TKey,TValue] environmentVariables, System.Boolean hide_output, System.Nullable`1[T] timeout) [0x00008] in <1b53e5c0c29b4df282039c569d8e4e35>:0 
17:59:26.2418400   at Xamarin.MTouch.RunUnitTest (Xamarin.Tests.Profile profile, System.String code, System.String csproj_configuration, System.String[] csproj_references, System.String configuration, System.String platform, System.Boolean clean_simulator) [0x001b9] in <1b53e5c0c29b4df282039c569d8e4e35>:0 
17:59:26.2418570   at Xamarin.MTouch.HttpClientHandler (System.String mtouchHandler, System.String expectedHandler) [0x0002d] in <1b53e5c0c29b4df282039c569d8e4e35>:0 
17:59:26.2418730   at (wrapper managed-to-native) System.Reflection.RuntimeMethodInfo.InternalInvoke(System.Reflection.RuntimeMethodInfo,object,object[],System.Exception&)
17:59:26.2419150   at System.Reflection.RuntimeMethodInfo.Invoke (System.Object obj, System.Reflection.BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x0006a] in <dd436d8b1aa7421eb3bcf48b995163c4>:0 

[mandel-macaque]

@chamons failures are a known issue: https://github.com/xamarin/maccore/issues/1028

[chamons]

@monojenkins backport main