Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[msbuild] Stop supporting watchOS 1 apps. #9542

Merged
merged 1 commit into from
Aug 28, 2020
Merged

[msbuild] Stop supporting watchOS 1 apps. #9542

merged 1 commit into from
Aug 28, 2020

Conversation

rolfbjarne
Copy link
Member

We can delete much more code, but that can be done later, to avoid the
potential for merge conflicts when merging the xcode12 branch back into main.

@rolfbjarne
[msbuild] Stop supporting watchOS 1 apps.
5a2e554 
We can delete much more code, but that can be done later, to avoid the
potential for merge conflicts when merging the xcode12 branch back into main.
@rolfbjarne rolfbjarne added run-msbuild-tests Run the (iOS) msbuild tests note-deprecation A deprecation that is worth mentioning in release notes note-highlight Worth calling out specifically in release notes and removed note-highlight Worth calling out specifically in release notes labels Aug 28, 2020
mandel-macaque
mandel-macaque approved these changes Aug 28, 2020
View reviewed changes
Copy link
Member

@mandel-macaque mandel-macaque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\0/

@monojenkins
Copy link
Collaborator

Build failure
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
🔥 Test run failed 🔥

Test results

1 tests failed, 78 tests passed.

Failed tests

  • MTouch tests/NUnit: Failed (Execution failed with exit code 5)

@rolfbjarne
Copy link
Member Author

Test failure is unrelated (https://github.com/xamarin/maccore/issues/2154)

whitneyschmidt
whitneyschmidt approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@whitneyschmidt whitneyschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

chamons
chamons approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@chamons chamons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 👍

@rolfbjarne rolfbjarne merged commit e5e9ff9 into xamarin:xcode12 Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spouliot spouliot spouliot approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@chamons chamons chamons approved these changes

@whitneyschmidt whitneyschmidt whitneyschmidt approved these changes

@emaf emaf Awaiting requested review from emaf emaf is a code owner

Assignees
No one assigned
Labels
note-deprecation A deprecation that is worth mentioning in release notes run-msbuild-tests Run the (iOS) msbuild tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rolfbjarne @monojenkins @spouliot @mandel-macaque @chamons @whitneyschmidt