[NetworkExtensions] Update framework to Xcode12 beta 6. #9585
Conversation
mandel-macaque
added
the
note-highlight
|
Build success |
Co-authored-by: Alex Soto <alex@alexsoto.me>
|
Build success |
Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
|
Build success |
src/networkextension.cs
Outdated
|
|
||
| [Notification] | ||
| [Field ("NEDNSSettingsConfigurationDidChangeNotification")] | ||
| NSString ConfigurationDidChangeNotification { get; } |
There was a problem hiding this comment.
from its name it looks like it should be on NEDnsSettings and not on NEDnsOverHttpsSettings
…acaque/xamarin-macios into network-extension-xcode12-beta6
src/networkextension.cs
Outdated
| @@ -327,6 +327,11 @@ interface NEDnsSettings : NSSecureCoding, NSCopying | |||
| [NoWatch, NoTV, Mac (11, 0), iOS (14, 0)] | |||
| [Export ("dnsProtocol")] | |||
| NEDnsProtocol DnsProtocol { get; } | |||
|
|
|||
| [Mac (11,0), iOS (14,0), NoTV] | |||
There was a problem hiding this comment.
it should either be [NoWatch] (like above) or [Watch (7,0)]
unless there's defines (that I don't see in the diff) the current attributes makes it available on watchOS 2.0
There was a problem hiding this comment.
NetworkExtension is not present on the watch
|
Build failure ✅ Build succeeded |
|
Build success |
No description provided.