fs/ntfs3: Fix NULL pointer dereference on error in attr_allocate_frame()

[ Upstream commit 9c689c8 ] Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
xanmod · Nov 8, 2023 · 0030ccd · 0030ccd
1 parent 3228a2e
commit 0030ccd
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/fs/ntfs3/attrib.c b/fs/ntfs3/attrib.c
@@ -1736,10 +1736,8 @@ int attr_allocate_frame(struct ntfs_inode *ni, CLST frame, size_t compr_size,
 			le_b = NULL;
 			attr_b = ni_find_attr(ni, NULL, &le_b, ATTR_DATA, NULL,
 					      0, NULL, &mi_b);
-			if (!attr_b) {
-				err = -ENOENT;
-				goto out;
-			}
+			if (!attr_b)
+				return -ENOENT;
 
 			attr = attr_b;
 			le = le_b;