Skip to content

Commit

Permalink
Revert "arm: sun8i: orangepi-pc-plus: Set EMAC activity LEDs to activ…
Browse files Browse the repository at this point in the history
…e high"

[ Upstream commit 8d80e2f ]

This reverts commit 75ee680.

Turns out the activity and link LEDs on the RJ45 port are active low,
just like on the Orange Pi PC.

Revert the commit that says otherwise.

Fixes: 75ee680 ("arm: sun8i: orangepi-pc-plus: Set EMAC activity LEDs to active high")
Fixes: 4904337 ("ARM: dts: sunxi: Restore EMAC changes (boards)")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Tested-by: Jernej Skrabec <jernej.skrabec@siol.net>
Acked-by: Jernej Skrabec <jernej.skrabec@siol.net>
Link: https://lore.kernel.org/r/20201024162515.30032-1-wens@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
wens authored and gregkh committed Nov 24, 2020
1 parent 58a5689 commit 018b3de
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions arch/arm/boot/dts/sun8i-h3-orangepi-pc-plus.dts
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,6 @@
};
};

&emac {
/* LEDs changed to active high on the plus */
/delete-property/ allwinner,leds-active-low;
};

&mmc1 {
vmmc-supply = <&reg_vcc3v3>;
bus-width = <4>;
Expand Down

0 comments on commit 018b3de

Please sign in to comment.