Skip to content

Commit

Permalink
selftest: net: fix typo in altname test
Browse files Browse the repository at this point in the history
commit 1b704b2 upstream.

If altname deletion of the short alternative name fails, the error
message printed is: "Failed to add short alternative name".
This is obviously a typo, as we are testing altname deletion.

Fix this using a proper error message.

Fixes: f95e6c9 ("selftest: net: add alternative names test")
Signed-off-by: Andrea Claudi <aclaudi@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
whispererindarkness authored and gregkh committed Sep 22, 2021
1 parent 88ed682 commit 01d9358
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/testing/selftests/net/altnames.sh
Expand Up @@ -45,7 +45,7 @@ altnames_test()
check_err $? "Got unexpected long alternative name from link show JSON"

ip link property del $DUMMY_DEV altname $SHORT_NAME
check_err $? "Failed to add short alternative name"
check_err $? "Failed to delete short alternative name"

ip -j -p link show $SHORT_NAME &>/dev/null
check_fail $? "Unexpected success while trying to do link show with deleted short alternative name"
Expand Down

0 comments on commit 01d9358

Please sign in to comment.