Skip to content

Commit

Permalink
mmc: f-sdh30: fix order of function calls in sdhci_f_sdh30_remove
Browse files Browse the repository at this point in the history
commit 58abdd8 upstream.

The order of function calls in sdhci_f_sdh30_remove is wrong,
let's call sdhci_pltfm_unregister first.

Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Fixes: 5def5c1 ("mmc: sdhci-f-sdh30: Replace with sdhci_pltfm")
Signed-off-by: Yangtao Li <frank.li@vivo.com>
Reported-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20230727070051.17778-62-frank.li@vivo.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
bbkzz authored and gregkh committed Aug 23, 2023
1 parent b2c55af commit 0768ecc
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions drivers/mmc/host/sdhci_f_sdh30.c
Expand Up @@ -188,12 +188,14 @@ static int sdhci_f_sdh30_remove(struct platform_device *pdev)
{
struct sdhci_host *host = platform_get_drvdata(pdev);
struct f_sdhost_priv *priv = sdhci_f_sdhost_priv(host);

clk_disable_unprepare(priv->clk_iface);
clk_disable_unprepare(priv->clk);
struct clk *clk_iface = priv->clk_iface;
struct clk *clk = priv->clk;

sdhci_pltfm_unregister(pdev);

clk_disable_unprepare(clk_iface);
clk_disable_unprepare(clk);

return 0;
}

Expand Down

0 comments on commit 0768ecc

Please sign in to comment.