Skip to content

Commit

Permalink
clk: qcom: turingcc-qcs404: fix missing resume during probe
Browse files Browse the repository at this point in the history
commit a9f71a0 upstream.

Drivers that enable runtime PM must make sure that the controller is
runtime resumed before accessing its registers to prevent the power
domain from being disabled.

Fixes: 892df01 ("clk: qcom: Add QCS404 TuringCC")
Cc: stable@vger.kernel.org      # 5.2
Cc: Bjorn Andersson <andersson@kernel.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Link: https://lore.kernel.org/r/20230718132902.21430-9-johan+linaro@kernel.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
jhovold authored and gregkh committed Sep 19, 2023
1 parent ac47243 commit 0cf2105
Showing 1 changed file with 12 additions and 1 deletion.
13 changes: 12 additions & 1 deletion drivers/clk/qcom/turingcc-qcs404.c
Expand Up @@ -125,11 +125,22 @@ static int turingcc_probe(struct platform_device *pdev)
return ret;
}

ret = pm_runtime_resume_and_get(&pdev->dev);
if (ret)
return ret;

ret = qcom_cc_probe(pdev, &turingcc_desc);
if (ret < 0)
return ret;
goto err_put_rpm;

pm_runtime_put(&pdev->dev);

return 0;

err_put_rpm:
pm_runtime_put_sync(&pdev->dev);

return ret;
}

static const struct dev_pm_ops turingcc_pm_ops = {
Expand Down

0 comments on commit 0cf2105

Please sign in to comment.