Skip to content

Commit

Permalink
ARM: dts: meson8b: odroidc1: Fix the pwm regulator supply properties
Browse files Browse the repository at this point in the history
[ Upstream commit 876228e ]

After enabling CONFIG_REGULATOR_DEBUG=y we observe below debug logs.
Changes help link VCCK and VDDEE pwm regulator to 5V regulator supply
instead of dummy regulator.

[    7.117140] pwm-regulator regulator-vcck: Looking up pwm-supply from device tree
[    7.117153] pwm-regulator regulator-vcck: Looking up pwm-supply property in node /regulator-vcck failed
[    7.117184] VCCK: supplied by regulator-dummy
[    7.117194] regulator-dummy: could not add device link regulator.8: -ENOENT
[    7.117266] VCCK: 860 <--> 1140 mV at 986 mV, enabled
[    7.118498] VDDEE: will resolve supply early: pwm
[    7.118515] pwm-regulator regulator-vddee: Looking up pwm-supply from device tree
[    7.118526] pwm-regulator regulator-vddee: Looking up pwm-supply property in node /regulator-vddee failed
[    7.118553] VDDEE: supplied by regulator-dummy
[    7.118563] regulator-dummy: could not add device link regulator.9: -ENOENT

Fixes: 524d960 ("ARM: dts: meson8b: odroidc1: add the CPU voltage regulator")
Fixes: 8bdf38b ("ARM: dts: meson8b: odroidc1: add the VDDEE regulator")

Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
[narmstrong: fixed typo in commit s/observer/observe/]
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Link: https://lore.kernel.org/r/20210705112358.3554-2-linux.amoon@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
moonlinux authored and gregkh committed Sep 15, 2021
1 parent eda87dd commit 0d40e59
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions arch/arm/boot/dts/meson8b-odroidc1.dts
Expand Up @@ -136,7 +136,7 @@
regulator-min-microvolt = <860000>;
regulator-max-microvolt = <1140000>;

vin-supply = <&p5v0>;
pwm-supply = <&p5v0>;

pwms = <&pwm_cd 0 12218 0>;
pwm-dutycycle-range = <91 0>;
Expand Down Expand Up @@ -168,7 +168,7 @@
regulator-min-microvolt = <860000>;
regulator-max-microvolt = <1140000>;

vin-supply = <&p5v0>;
pwm-supply = <&p5v0>;

pwms = <&pwm_cd 1 12218 0>;
pwm-dutycycle-range = <91 0>;
Expand Down

0 comments on commit 0d40e59

Please sign in to comment.