Skip to content

Commit

Permalink
net: ipa: fix page free in ipa_endpoint_trans_release()
Browse files Browse the repository at this point in the history
commit 155c0c9 upstream.

Currently the (possibly compound) page used for receive buffers are
freed using __free_pages().  But according to this comment above the
definition of that function, that's wrong:
    If you want to use the page's reference count to decide when
    to free the allocation, you should allocate a compound page,
    and use put_page() instead of __free_pages().

Convert the call to __free_pages() in ipa_endpoint_trans_release()
to use put_page() instead.

Fixes: ed23f02 ("net: ipa: define per-endpoint receive buffer size")
Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
alexelder authored and gregkh committed Jun 9, 2022
1 parent 8c03eb0 commit 0ec5664
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions drivers/net/ipa/ipa_endpoint.c
Expand Up @@ -1385,11 +1385,8 @@ void ipa_endpoint_trans_release(struct ipa_endpoint *endpoint,
} else {
struct page *page = trans->data;

if (page) {
u32 buffer_size = endpoint->data->rx.buffer_size;

__free_pages(page, get_order(buffer_size));
}
if (page)
put_page(page);
}
}

Expand Down

0 comments on commit 0ec5664

Please sign in to comment.