Skip to content

Commit

Permalink
clk: qcom: gcc-ipq8074: fix terminating of frequency table arrays
Browse files Browse the repository at this point in the history
The frequency table arrays are supposed to be terminated with an
empty element. Add such entry to the end of the arrays where it
is missing in order to avoid possible out-of-bound access when
the table is traversed by functions like qcom_find_freq() or
qcom_find_freq_floor().

Only compile tested.

Fixes: 9607f62 ("clk: qcom: ipq8074: add PCIE, USB and SDCC clocks")
Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20240229-freq-table-terminator-v1-3-074334f0905c@gmail.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
  • Loading branch information
juhosg authored and andersson committed Mar 2, 2024
1 parent cdbc6e2 commit 1040ef5
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions drivers/clk/qcom/gcc-ipq8074.c
Original file line number Diff line number Diff line change
Expand Up @@ -644,6 +644,7 @@ static struct clk_rcg2 pcie0_axi_clk_src = {

static const struct freq_tbl ftbl_pcie_aux_clk_src[] = {
F(19200000, P_XO, 1, 0, 0),
{ }
};

static const struct clk_parent_data gcc_xo_gpll0_sleep_clk[] = {
Expand Down Expand Up @@ -795,6 +796,7 @@ static const struct freq_tbl ftbl_sdcc_ice_core_clk_src[] = {
F(19200000, P_XO, 1, 0, 0),
F(160000000, P_GPLL0, 5, 0, 0),
F(308570000, P_GPLL6, 3.5, 0, 0),
{ }
};

static const struct clk_parent_data gcc_xo_gpll0_gpll6_gpll0_div2[] = {
Expand Down

0 comments on commit 1040ef5

Please sign in to comment.