Skip to content

Commit

Permalink
block: fix a race between del_gendisk and BLKRRPART
Browse files Browse the repository at this point in the history
[ Upstream commit bc6a385 ]

When BLKRRPART is called concurrently with del_gendisk, the partitions
rescan can create a stale partition that will never be be cleaned up.

Fix this by checking the the disk is up before rescanning partitions
while under bd_mutex.

Signed-off-by: Gulam Mohamed <gulam.mohamed@oracle.com>
[hch: split from a larger patch]
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/20210514131842.1600568-3-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
gulams authored and gregkh committed Jun 3, 2021
1 parent 61b0308 commit 1196f05
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions fs/block_dev.c
Expand Up @@ -1244,6 +1244,9 @@ int bdev_disk_changed(struct block_device *bdev, bool invalidate)

lockdep_assert_held(&bdev->bd_mutex);

if (!(disk->flags & GENHD_FL_UP))
return -ENXIO;

rescan:
ret = blk_drop_partitions(bdev);
if (ret)
Expand Down

0 comments on commit 1196f05

Please sign in to comment.