Skip to content

Commit

Permalink
ARM: dts: meson: fix PHY deassert timing requirements
Browse files Browse the repository at this point in the history
[ Upstream commit 656ab1b ]

According to the datasheet (Rev. 1.9) the RTL8211F requires at least
72ms "for internal circuits settling time" before accessing the PHY
registers. On similar boards with the same PHY this fixes an issue where
Ethernet link would not come up when using ip link set down/up.

Fixes: a2c6e82 ("ARM: dts: meson: switch to the generic Ethernet PHY reset bindings")
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> # on Odroid-C1+
Signed-off-by: Stefan Agner <stefan@agner.ch>
Signed-off-by: Kevin Hilman <khilman@baylibre.com>
Link: https://lore.kernel.org/r/ff78772b306411e145769c46d4090554344db41e.1607363522.git.stefan@agner.ch
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
agners authored and gregkh committed Dec 30, 2020
1 parent 154105c commit 13f4c61
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion arch/arm/boot/dts/meson8b-odroidc1.dts
Expand Up @@ -219,7 +219,7 @@
reg = <0>;

reset-assert-us = <10000>;
reset-deassert-us = <30000>;
reset-deassert-us = <80000>;
reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;

interrupt-parent = <&gpio_intc>;
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/boot/dts/meson8m2-mxiii-plus.dts
Expand Up @@ -83,7 +83,7 @@
reg = <0>;

reset-assert-us = <10000>;
reset-deassert-us = <30000>;
reset-deassert-us = <80000>;
reset-gpios = <&gpio GPIOH_4 GPIO_ACTIVE_LOW>;
};
};
Expand Down

0 comments on commit 13f4c61

Please sign in to comment.