Skip to content

Commit

Permalink
drm/tve200: Fix handling of platform_get_irq() error
Browse files Browse the repository at this point in the history
[ Upstream commit 77bb5aa ]

platform_get_irq() returns -ERRNO on error.  In such case comparison
to 0 would pass the check.

Fixes: 179c02f ("drm/tve200: Add new driver for TVE200")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20200827071107.27429-2-krzk@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
krzk authored and gregkh committed Dec 30, 2020
1 parent 22bf070 commit 172b722
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/gpu/drm/tve200/tve200_drv.c
Expand Up @@ -200,8 +200,8 @@ static int tve200_probe(struct platform_device *pdev)
}

irq = platform_get_irq(pdev, 0);
if (!irq) {
ret = -EINVAL;
if (irq < 0) {
ret = irq;
goto clk_disable;
}

Expand Down

0 comments on commit 172b722

Please sign in to comment.