Skip to content

Commit

Permalink
seq_file: disallow extremely large seq buffer allocations
Browse files Browse the repository at this point in the history
commit 8cae8cd upstream.

There is no reasonable need for a buffer larger than this, and it avoids
int overflow pitfalls.

Fixes: 058504e ("fs/seq_file: fallback to vmalloc allocation")
Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
Reported-by: Qualys Security Advisory <qsa@qualys.com>
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Cc: stable@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Eric Sandeen authored and gregkh committed Jul 20, 2021
1 parent b33aa0d commit 174c34d
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions fs/seq_file.c
Expand Up @@ -32,6 +32,9 @@ static void seq_set_overflow(struct seq_file *m)

static void *seq_buf_alloc(unsigned long size)
{
if (unlikely(size > MAX_RW_COUNT))
return NULL;

return kvmalloc(size, GFP_KERNEL_ACCOUNT);
}

Expand Down

0 comments on commit 174c34d

Please sign in to comment.