Skip to content

Commit

Permalink
Bluetooth: btsdio: fix use after free bug in btsdio_remove due to rac…
Browse files Browse the repository at this point in the history
…e condition

commit 73f7b17 upstream.

In btsdio_probe, the data->work is bound with btsdio_work. It will be
started in btsdio_send_frame.

If the btsdio_remove runs with a unfinished work, there may be a race
condition that hdev is freed but used in btsdio_work. Fix it by
canceling the work before do cleanup in btsdio_remove.

Fixes: CVE-2023-1989
Fixes: ddbaf13 ("[Bluetooth] Add generic driver for Bluetooth SDIO devices")
Cc: stable@vger.kernel.org
Signed-off-by: Zheng Wang <zyytlz.wz@163.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
[ Denis: Added CVE-2023-1989 and fixes tags. ]
Signed-off-by: Denis Efremov (Oracle) <efremov@linux.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Zheng Wang authored and gregkh committed Sep 6, 2023
1 parent 86b818e commit 179c658
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/bluetooth/btsdio.c
Expand Up @@ -357,6 +357,7 @@ static void btsdio_remove(struct sdio_func *func)
if (!data)
return;

cancel_work_sync(&data->work);
hdev = data->hdev;

sdio_set_drvdata(func, NULL);
Expand Down

0 comments on commit 179c658

Please sign in to comment.