Skip to content

Commit

Permalink
media: venus: helper: do not set constrained parameters for UBWC
Browse files Browse the repository at this point in the history
[ Upstream commit 1ac61fa ]

Plane constraints firmware interface is to override the default
alignment for a given color format. By default venus hardware has
alignments as 128x32, but NV12 was defined differently to meet
various usecases. Compressed NV12 has always been aligned as 128x32,
hence not needed to override the default alignment.

Fixes: bc28936 ("media: venus: helpers, hfi, vdec: Set actual plane constraints to FW")
Signed-off-by: Mansur Alisha Shaik <mansur@codeaurora.org>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Mansur Alisha Shaik authored and gregkh committed Sep 15, 2021
1 parent be54585 commit 182ee4d
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/media/platform/qcom/venus/helpers.c
Expand Up @@ -1138,6 +1138,9 @@ int venus_helper_set_format_constraints(struct venus_inst *inst)
if (!IS_V6(inst->core))
return 0;

if (inst->opb_fmt == HFI_COLOR_FORMAT_NV12_UBWC)
return 0;

pconstraint.buffer_type = HFI_BUFFER_OUTPUT2;
pconstraint.num_planes = 2;
pconstraint.plane_format[0].stride_multiples = 128;
Expand Down

0 comments on commit 182ee4d

Please sign in to comment.