Skip to content

Commit

Permalink
mfd: rn5t618: Fix IRQ trigger by changing it to level mode
Browse files Browse the repository at this point in the history
[ Upstream commit a1649a5 ]

During more massive generation of interrupts, the IRQ got stuck,
and the subdevices did not see any new interrupts. That happens
especially at wonky USB supply in combination with ADC reads.
To fix that trigger the IRQ at level low instead of falling edge.

Fixes: 0c81604 ("mfd: rn5t618: Add IRQ support")
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
akemnade authored and gregkh committed Jul 14, 2021
1 parent d28e4dd commit 1ad0a8b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/mfd/rn5t618.c
Expand Up @@ -104,7 +104,7 @@ static int rn5t618_irq_init(struct rn5t618 *rn5t618)

ret = devm_regmap_add_irq_chip(rn5t618->dev, rn5t618->regmap,
rn5t618->irq,
IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
IRQF_TRIGGER_LOW | IRQF_ONESHOT,
0, irq_chip, &rn5t618->irq_data);
if (ret)
dev_err(rn5t618->dev, "Failed to register IRQ chip\n");
Expand Down

0 comments on commit 1ad0a8b

Please sign in to comment.