Skip to content

Commit

Permalink
dmaengine: usb-dmac: Fix PM reference leak in usb_dmac_probe()
Browse files Browse the repository at this point in the history
pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by moving the error_pm label above the pm_runtime_put() in
the error path.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Link: https://lore.kernel.org/r/20210706124521.1371901-1-yukuai3@huawei.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
  • Loading branch information
Yu Kuai authored and vinodkoul committed Jul 14, 2021
1 parent 7dd2dd4 commit 1da569f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/dma/sh/usb-dmac.c
Original file line number Diff line number Diff line change
Expand Up @@ -855,8 +855,8 @@ static int usb_dmac_probe(struct platform_device *pdev)

error:
of_dma_controller_free(pdev->dev.of_node);
pm_runtime_put(&pdev->dev);
error_pm:
pm_runtime_put(&pdev->dev);
pm_runtime_disable(&pdev->dev);
return ret;
}
Expand Down

0 comments on commit 1da569f

Please sign in to comment.