Skip to content

Commit

Permalink
net/nfc/rawsock.c: fix a permission check bug
Browse files Browse the repository at this point in the history
[ Upstream commit 8ab7886 ]

The function rawsock_create() calls a privileged function sk_alloc(), which requires a ns-aware check to check net->user_ns, i.e., ns_capable(). However, the original code checks the init_user_ns using capable(). So we replace the capable() with ns_capable().

Signed-off-by: Jeimon <jjjinmeng.zhou@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Jeimon authored and gregkh committed Jun 16, 2021
1 parent 584b2c7 commit 1e5cab5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/nfc/rawsock.c
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ static int rawsock_create(struct net *net, struct socket *sock,
return -ESOCKTNOSUPPORT;

if (sock->type == SOCK_RAW) {
if (!capable(CAP_NET_RAW))
if (!ns_capable(net->user_ns, CAP_NET_RAW))
return -EPERM;
sock->ops = &rawsock_raw_ops;
} else {
Expand Down

0 comments on commit 1e5cab5

Please sign in to comment.