Skip to content

Commit

Permalink
fpga: altera-pr-ip: fix unsigned comparison with less than zero
Browse files Browse the repository at this point in the history
[ Upstream commit 2df84a7 ]

Fix the "comparison with less than zero" warning reported by
cppcheck for the unsigned (size_t) parameter count of the
alt_pr_fpga_write() function.

Fixes: d201cc1 ("fpga pr ip: Core driver support for Altera Partial Reconfiguration IP")
Reviewed-by: Tom Rix <trix@redhat.com>
Acked-by: Xu Yilun <yilun.xu@intel.com>
Signed-off-by: Marco Pagani <marpagan@redhat.com>
Link: https://lore.kernel.org/r/20220609140520.42662-1-marpagan@redhat.com
Signed-off-by: Xu Yilun <yilun.xu@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Marco Pagani authored and gregkh committed Aug 17, 2022
1 parent 0675fe2 commit 1e5ec5e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/fpga/altera-pr-ip-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ static int alt_pr_fpga_write(struct fpga_manager *mgr, const char *buf,
u32 *buffer_32 = (u32 *)buf;
size_t i = 0;

if (count <= 0)
if (!count)
return -EINVAL;

/* Write out the complete 32-bit chunks */
Expand Down

0 comments on commit 1e5ec5e

Please sign in to comment.