Skip to content

Commit

Permalink
net/sched: sch_clsact: Only create under TC_H_CLSACT
Browse files Browse the repository at this point in the history
[ Upstream commit 5eeebfe ]

clsact Qdiscs are only supposed to be created under TC_H_CLSACT (which
equals TC_H_INGRESS).  Return -EOPNOTSUPP if 'parent' is not
TC_H_CLSACT.

Fixes: 1f211a1 ("net, sched: add clsact qdisc")
Tested-by: Pedro Tammela <pctammela@mojatatu.com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Reviewed-by: Jamal Hadi Salim <jhs@mojatatu.com>
Reviewed-by: Vlad Buslov <vladbu@nvidia.com>
Signed-off-by: Peilin Ye <peilin.ye@bytedance.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
ypl-coffee authored and gregkh committed Jun 9, 2023
1 parent 89a0f4d commit 1ec1434
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions net/sched/sch_ingress.c
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,9 @@ static int clsact_init(struct Qdisc *sch, struct nlattr *opt,
struct net_device *dev = qdisc_dev(sch);
int err;

if (sch->parent != TC_H_CLSACT)
return -EOPNOTSUPP;

net_inc_ingress_queue();
net_inc_egress_queue();

Expand Down Expand Up @@ -254,6 +257,9 @@ static void clsact_destroy(struct Qdisc *sch)
{
struct clsact_sched_data *q = qdisc_priv(sch);

if (sch->parent != TC_H_CLSACT)
return;

tcf_block_put_ext(q->egress_block, sch, &q->egress_block_info);
tcf_block_put_ext(q->ingress_block, sch, &q->ingress_block_info);

Expand Down

0 comments on commit 1ec1434

Please sign in to comment.