Skip to content

Commit

Permalink
media: mceusb: return without resubmitting URB in case of -EPROTO error.
Browse files Browse the repository at this point in the history
[ Upstream commit 476db72 ]

Syzkaller reported a warning called "rcu detected stall in dummy_timer".

The error seems to be an error in mceusb_dev_recv(). In the case of
-EPROTO error, the routine immediately resubmits the URB. Instead it
should return without resubmitting URB.

Reported-by: syzbot+4d3749e9612c2cfab956@syzkaller.appspotmail.com
Signed-off-by: Rajat Asthana <rajatasthana4@gmail.com>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
rast-7 authored and gregkh committed Nov 17, 2021
1 parent 6e0202d commit 1f7d529
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/media/rc/mceusb.c
Expand Up @@ -1386,6 +1386,7 @@ static void mceusb_dev_recv(struct urb *urb)
case -ECONNRESET:
case -ENOENT:
case -EILSEQ:
case -EPROTO:
case -ESHUTDOWN:
usb_unlink_urb(urb);
return;
Expand Down

0 comments on commit 1f7d529

Please sign in to comment.