Skip to content

Commit

Permalink
usb: musb: mpfs: Fix error codes in probe()
Browse files Browse the repository at this point in the history
These error paths return success but they need to return a negative
error code.

Fixes: 7a96b6e ("usb: musb: Add support for PolarFire SoC's musb controller")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/YrVmLEc/FOEzNdzj@kili
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Dan Carpenter authored and gregkh committed Jun 24, 2022
1 parent 105f3fd commit 21cdd6a
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion drivers/usb/musb/mpfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -181,8 +181,10 @@ static int mpfs_probe(struct platform_device *pdev)
glue->clk = clk;

pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
if (!pdata)
if (!pdata) {
ret = -ENOMEM;
goto err_clk_disable;
}

pdata->config = &mpfs_musb_hdrc_config;
pdata->platform_ops = &mpfs_ops;
Expand All @@ -197,6 +199,7 @@ static int mpfs_probe(struct platform_device *pdev)
if (IS_ERR(glue->phy)) {
dev_err(dev, "failed to register usb-phy %ld\n",
PTR_ERR(glue->phy));
ret = PTR_ERR(glue->phy);
goto err_clk_disable;
}

Expand Down

0 comments on commit 21cdd6a

Please sign in to comment.