Skip to content

Commit

Permalink
mac80211: Fix insufficient headroom issue for AMSDU
Browse files Browse the repository at this point in the history
[ Upstream commit f50d2ff ]

ieee80211_amsdu_realloc_pad() fails to account for extra_tx_headroom,
the original reserved headroom might be eaten. Add the necessary
extra_tx_headroom.

Fixes: 6e0456b ("mac80211: add A-MSDU tx support")
Signed-off-by: Chih-Kang Chang <gary.chang@realtek.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Link: https://lore.kernel.org/r/20210816085128.10931-2-pkshih@realtek.com
[fix indentation]
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Chih-Kang Chang authored and gregkh committed Sep 15, 2021
1 parent 0ad4ddb commit 22b106d
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion net/mac80211/tx.c
Expand Up @@ -3229,7 +3229,9 @@ static bool ieee80211_amsdu_prepare_head(struct ieee80211_sub_if_data *sdata,
if (info->control.flags & IEEE80211_TX_CTRL_AMSDU)
return true;

if (!ieee80211_amsdu_realloc_pad(local, skb, sizeof(*amsdu_hdr)))
if (!ieee80211_amsdu_realloc_pad(local, skb,
sizeof(*amsdu_hdr) +
local->hw.extra_tx_headroom))
return false;

data = skb_push(skb, sizeof(*amsdu_hdr));
Expand Down

0 comments on commit 22b106d

Please sign in to comment.