Skip to content

Commit

Permalink
selftests/net: rxtimestamp: fix clang issues for target arch PowerPC
Browse files Browse the repository at this point in the history
[ Upstream commit 955cbe9 ]

The signedness of char is implementation-dependent. Some systems
(including PowerPC and ARM) use unsigned char. Clang 9 threw:
warning: result of comparison of constant -1 with expression of type \
'char' is always true [-Wtautological-constant-out-of-range-compare]
                                  &arg_index)) != -1) {

Tested: make -C tools/testing/selftests TARGETS="net" run_tests

Fixes: 16e7812 ("selftests/net: Add a test to validate behavior of rx timestamps")
Signed-off-by: Tanner Love <tannerlove@google.com>
Acked-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
tannerlove authored and gregkh committed Aug 5, 2020
1 parent 831c904 commit 22f84cc
Showing 1 changed file with 1 addition and 2 deletions.
Expand Up @@ -329,8 +329,7 @@ int main(int argc, char **argv)
bool all_tests = true;
int arg_index = 0;
int failures = 0;
int s, t;
char opt;
int s, t, opt;

while ((opt = getopt_long(argc, argv, "", long_options,
&arg_index)) != -1) {
Expand Down

0 comments on commit 22f84cc

Please sign in to comment.