Skip to content

Commit

Permalink
spi: stm32: fixes suspend/resume management
Browse files Browse the repository at this point in the history
[ Upstream commit db96bf9 ]

This patch adds pinctrl power management, and reconfigure spi controller
in case of resume.

Fixes: 038ac86 ("spi: stm32: add runtime PM support")

Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
Signed-off-by: Alain Volmat <alain.volmat@st.com>
Link: https://lore.kernel.org/r/1597043558-29668-5-git-send-email-alain.volmat@st.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
ADESTM authored and gregkh committed Aug 26, 2020
1 parent 666d1d1 commit 233d6f2
Showing 1 changed file with 24 additions and 3 deletions.
27 changes: 24 additions & 3 deletions drivers/spi/spi-stm32.c
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
#include <linux/iopoll.h>
#include <linux/module.h>
#include <linux/of_platform.h>
#include <linux/pinctrl/consumer.h>
#include <linux/pm_runtime.h>
#include <linux/reset.h>
#include <linux/spi/spi.h>
Expand Down Expand Up @@ -1986,6 +1987,8 @@ static int stm32_spi_remove(struct platform_device *pdev)

pm_runtime_disable(&pdev->dev);

pinctrl_pm_select_sleep_state(&pdev->dev);

return 0;
}

Expand All @@ -1997,13 +2000,18 @@ static int stm32_spi_runtime_suspend(struct device *dev)

clk_disable_unprepare(spi->clk);

return 0;
return pinctrl_pm_select_sleep_state(dev);
}

static int stm32_spi_runtime_resume(struct device *dev)
{
struct spi_master *master = dev_get_drvdata(dev);
struct stm32_spi *spi = spi_master_get_devdata(master);
int ret;

ret = pinctrl_pm_select_default_state(dev);
if (ret)
return ret;

return clk_prepare_enable(spi->clk);
}
Expand Down Expand Up @@ -2033,10 +2041,23 @@ static int stm32_spi_resume(struct device *dev)
return ret;

ret = spi_master_resume(master);
if (ret)
if (ret) {
clk_disable_unprepare(spi->clk);
return ret;
}

return ret;
ret = pm_runtime_get_sync(dev);
if (ret) {
dev_err(dev, "Unable to power device:%d\n", ret);
return ret;
}

spi->cfg->config(spi);

pm_runtime_mark_last_busy(dev);
pm_runtime_put_autosuspend(dev);

return 0;
}
#endif

Expand Down

0 comments on commit 233d6f2

Please sign in to comment.