Skip to content

Commit

Permalink
ethtool: Fix an error code in cxgb2.c
Browse files Browse the repository at this point in the history
[ Upstream commit 7db8263 ]

When adapter->registered_device_map is NULL, the value of err is
uncertain, we set err to -EINVAL to avoid ambiguity.

Clean up smatch warning:
drivers/net/ethernet/chelsio/cxgb/cxgb2.c:1114 init_one() warn: missing
error code 'err'

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Yang Li authored and gregkh committed Sep 22, 2021
1 parent 0fc6568 commit 23edad3
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/net/ethernet/chelsio/cxgb/cxgb2.c
Expand Up @@ -1107,6 +1107,7 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
if (!adapter->registered_device_map) {
pr_err("%s: could not register any net devices\n",
pci_name(pdev));
err = -EINVAL;
goto out_release_adapter_res;
}

Expand Down

0 comments on commit 23edad3

Please sign in to comment.