Skip to content

Commit

Permalink
Bluetooth: hci_h5: fix memory leak in h5_close
Browse files Browse the repository at this point in the history
[ Upstream commit 855af2d ]

When h5_close() is called, h5 is directly freed when !hu->serdev.
However, h5->rx_skb is not freed, which causes a memory leak.

Freeing h5->rx_skb and setting it to NULL, fixes this memory leak.

Fixes: ce94555 ("Bluetooth: hci_h5: Add support for serdev enumerated devices")
Reported-by: syzbot+6ce141c55b2f7aafd1c4@syzkaller.appspotmail.com
Tested-by: syzbot+6ce141c55b2f7aafd1c4@syzkaller.appspotmail.com
Signed-off-by: Anant Thazhemadam <anant.thazhemadam@gmail.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
thazhemadam authored and gregkh committed Dec 30, 2020
1 parent 5cf3c2e commit 25b5a48
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/bluetooth/hci_h5.c
Expand Up @@ -244,6 +244,9 @@ static int h5_close(struct hci_uart *hu)
skb_queue_purge(&h5->rel);
skb_queue_purge(&h5->unrel);

kfree_skb(h5->rx_skb);
h5->rx_skb = NULL;

if (h5->vnd && h5->vnd->close)
h5->vnd->close(h5);

Expand Down

0 comments on commit 25b5a48

Please sign in to comment.