Skip to content

Commit

Permalink
RDMA/rtrs: Do not signal for heatbeat
Browse files Browse the repository at this point in the history
commit b38041d upstream.

For HB, there is no need to generate signal for completion.

Also remove a comment accordingly.

Fixes: c0894b3 ("RDMA/rtrs: core: lib functions shared between client and server modules")
Link: https://lore.kernel.org/r/20201217141915.56989-16-jinpu.wang@cloud.ionos.com
Signed-off-by: Jack Wang <jinpu.wang@cloud.ionos.com>
Reported-by: Gioh Kim <gi-oh.kim@cloud.ionos.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Jack Wang authored and gregkh committed Mar 7, 2021
1 parent 2decd71 commit 27791ad
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 4 deletions.
1 change: 0 additions & 1 deletion drivers/infiniband/ulp/rtrs/rtrs-clt.c
Expand Up @@ -666,7 +666,6 @@ static void rtrs_clt_rdma_done(struct ib_cq *cq, struct ib_wc *wc)
case IB_WC_RDMA_WRITE:
/*
* post_send() RDMA write completions of IO reqs (read/write)
* and hb
*/
break;

Expand Down
1 change: 0 additions & 1 deletion drivers/infiniband/ulp/rtrs/rtrs-srv.c
Expand Up @@ -1244,7 +1244,6 @@ static void rtrs_srv_rdma_done(struct ib_cq *cq, struct ib_wc *wc)
case IB_WC_SEND:
/*
* post_send() RDMA write completions of IO reqs (read/write)
* and hb
*/
atomic_add(srv->queue_depth, &con->sq_wr_avail);

Expand Down
4 changes: 2 additions & 2 deletions drivers/infiniband/ulp/rtrs/rtrs.c
Expand Up @@ -310,7 +310,7 @@ void rtrs_send_hb_ack(struct rtrs_sess *sess)

imm = rtrs_to_imm(RTRS_HB_ACK_IMM, 0);
err = rtrs_post_rdma_write_imm_empty(usr_con, sess->hb_cqe, imm,
IB_SEND_SIGNALED, NULL);
0, NULL);
if (err) {
sess->hb_err_handler(usr_con);
return;
Expand Down Expand Up @@ -339,7 +339,7 @@ static void hb_work(struct work_struct *work)
}
imm = rtrs_to_imm(RTRS_HB_MSG_IMM, 0);
err = rtrs_post_rdma_write_imm_empty(usr_con, sess->hb_cqe, imm,
IB_SEND_SIGNALED, NULL);
0, NULL);
if (err) {
sess->hb_err_handler(usr_con);
return;
Expand Down

0 comments on commit 27791ad

Please sign in to comment.