Skip to content

Commit

Permalink
f2fs: drop dirty node pages when cp is in error status
Browse files Browse the repository at this point in the history
Otherwise, writeback is going to fall in a loop to flush dirty inode forever
before getting SBI_CLOSING.

Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
  • Loading branch information
Jaegeuk Kim committed Jul 7, 2021
1 parent c9ebd3d commit 28607bf
Showing 1 changed file with 4 additions and 7 deletions.
11 changes: 4 additions & 7 deletions fs/f2fs/node.c
Original file line number Diff line number Diff line change
Expand Up @@ -1549,13 +1549,10 @@ static int __write_node_page(struct page *page, bool atomic, bool *submitted,
trace_f2fs_writepage(page, NODE);

if (unlikely(f2fs_cp_error(sbi))) {
if (is_sbi_flag_set(sbi, SBI_IS_CLOSE)) {
ClearPageUptodate(page);
dec_page_count(sbi, F2FS_DIRTY_NODES);
unlock_page(page);
return 0;
}
goto redirty_out;
ClearPageUptodate(page);
dec_page_count(sbi, F2FS_DIRTY_NODES);
unlock_page(page);
return 0;
}

if (unlikely(is_sbi_flag_set(sbi, SBI_POR_DOING)))
Expand Down

0 comments on commit 28607bf

Please sign in to comment.