Skip to content

Commit

Permalink
Staging: ipack/devices/ipoctal: Check tty_register_device return value.
Browse files Browse the repository at this point in the history
Signed-off-by: Jens Taprogge <jens.taprogge@taprogge.org>
Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
jtaprogge authored and gregkh committed Sep 12, 2012
1 parent 1adda49 commit 2afb41d
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion drivers/staging/ipack/devices/ipoctal.c
Original file line number Diff line number Diff line change
Expand Up @@ -437,6 +437,8 @@ static int ipoctal_inst_slot(struct ipoctal *ipoctal, unsigned int bus_nr,
ipoctal->tty_drv = tty;

for (i = 0; i < NR_CHANNELS; i++) {
struct device *tty_dev;

channel = &ipoctal->channel[i];
tty_port_init(&channel->tty_port);
tty_port_alloc_xmit_buf(&channel->tty_port);
Expand All @@ -450,7 +452,11 @@ static int ipoctal_inst_slot(struct ipoctal *ipoctal, unsigned int bus_nr,
channel->pointer_read = 0;
channel->pointer_write = 0;
channel->nb_bytes = 0;
tty_register_device(tty, i, NULL);
tty_dev = tty_register_device(tty, i, NULL);
if (IS_ERR(tty_dev)) {
dev_err(&ipoctal->dev->dev, "Failed to register tty device.\n");
continue;
}

/*
* Enable again the RX. TX will be enabled when
Expand Down

0 comments on commit 2afb41d

Please sign in to comment.