Skip to content

Commit

Permalink
genirq/timings: Prevent potential array overflow in __irq_timings_sto…
Browse files Browse the repository at this point in the history
…re()

commit b9cc7d8 upstream.

When the interrupt interval is greater than 2 ^ PREDICTION_BUFFER_SIZE *
PREDICTION_FACTOR us and less than 1s, the calculated index will be greater
than the length of irqs->ema_time[]. Check the calculated index before
using it to prevent array overflow.

Fixes: 23aa3b9 ("genirq/timings: Encapsulate storing function")
Signed-off-by: Ben Dai <ben.dai@unisoc.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20210425150903.25456-1-ben.dai9703@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Ben Dai authored and gregkh committed Aug 18, 2021
1 parent 3557541 commit 2d2c668
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions kernel/irq/timings.c
Expand Up @@ -453,6 +453,11 @@ static __always_inline void __irq_timings_store(int irq, struct irqt_stat *irqs,
*/
index = irq_timings_interval_index(interval);

if (index > PREDICTION_BUFFER_SIZE - 1) {
irqs->count = 0;
return;
}

/*
* Store the index as an element of the pattern in another
* circular array.
Expand Down

0 comments on commit 2d2c668

Please sign in to comment.