Skip to content

Commit

Permalink
mmc: mxcmmc: fix return value check of mmc_add_host()
Browse files Browse the repository at this point in the history
[ Upstream commit cde600a ]

mmc_add_host() may return error, if we ignore its return value, the memory
that allocated in mmc_alloc_host() will be leaked and it will lead a kernel
crash because of deleting not added device in the remove path.

So fix this by checking the return value and goto error path which will call
mmc_free_host().

Fixes: d96be87 ("mmc: Add a MX2/MX3 specific SDHC driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221101063023.1664968-4-yangyingliang@huawei.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Yang Yingliang authored and gregkh committed Dec 31, 2022
1 parent f0502fe commit 2d49605
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/mmc/host/mxcmmc.c
Expand Up @@ -1143,7 +1143,9 @@ static int mxcmci_probe(struct platform_device *pdev)

timer_setup(&host->watchdog, mxcmci_watchdog, 0);

mmc_add_host(mmc);
ret = mmc_add_host(mmc);
if (ret)
goto out_free_dma;

return 0;

Expand Down

0 comments on commit 2d49605

Please sign in to comment.