Skip to content

Commit

Permalink
amd-xgbe: propagate the correct speed and duplex status
Browse files Browse the repository at this point in the history
[ Upstream commit 7a2323a ]

xgbe_get_link_ksettings() does not propagate correct speed and duplex
information to ethtool during cable unplug. Due to which ethtool reports
incorrect values for speed and duplex.

Address this by propagating correct information.

Fixes: 7c12aa0 ("amd-xgbe: Move the PHY support into amd-xgbe")
Acked-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Signed-off-by: Raju Rangoju <Raju.Rangoju@amd.com>
Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
RajuRangoju authored and gregkh committed Dec 3, 2023
1 parent 73d114d commit 3481ff3
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c
Original file line number Diff line number Diff line change
Expand Up @@ -314,10 +314,15 @@ static int xgbe_get_link_ksettings(struct net_device *netdev,

cmd->base.phy_address = pdata->phy.address;

cmd->base.autoneg = pdata->phy.autoneg;
cmd->base.speed = pdata->phy.speed;
cmd->base.duplex = pdata->phy.duplex;
if (netif_carrier_ok(netdev)) {
cmd->base.speed = pdata->phy.speed;
cmd->base.duplex = pdata->phy.duplex;
} else {
cmd->base.speed = SPEED_UNKNOWN;
cmd->base.duplex = DUPLEX_UNKNOWN;
}

cmd->base.autoneg = pdata->phy.autoneg;
cmd->base.port = PORT_NONE;

XGBE_LM_COPY(cmd, supported, lks, supported);
Expand Down

0 comments on commit 3481ff3

Please sign in to comment.