Skip to content

Commit

Permalink
spi: tegra20-sflash: fix reference leak in tegra_sflash_resume
Browse files Browse the repository at this point in the history
pm_runtime_get_sync will increment pm usage counter even it
failed. Forgetting to pm_runtime_put_noidle will result in
reference leak in tegra_sflash_resume, so we should fix it.

Fixes: 8528547 ("spi: tegra: add spi driver for sflash controller")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Link: https://lore.kernel.org/r/20201103141323.5841-1-zhangqilong3@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
Zhang Qilong authored and broonie committed Nov 9, 2020
1 parent 763eab7 commit 3482e79
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/spi/spi-tegra20-sflash.c
Original file line number Diff line number Diff line change
Expand Up @@ -552,6 +552,7 @@ static int tegra_sflash_resume(struct device *dev)

ret = pm_runtime_get_sync(dev);
if (ret < 0) {
pm_runtime_put_noidle(dev);
dev_err(dev, "pm runtime failed, e = %d\n", ret);
return ret;
}
Expand Down

0 comments on commit 3482e79

Please sign in to comment.