Skip to content

Commit

Permalink
usb: dwc3: Fix debugfs creation flow
Browse files Browse the repository at this point in the history
commit 84524d1 upstream.

Creation EP's debugfs called earlier than debugfs folder for dwc3
device created. As result EP's debugfs are created in '/sys/kernel/debug'
instead of '/sys/kernel/debug/usb/dwc3.1.auto'.

Moved dwc3_debugfs_init() function call before calling
dwc3_core_init_mode() to allow create dwc3 debugfs parent before
creating EP's debugfs's.

Fixes: 8d396bb ("usb: dwc3: debugfs: Add and remove endpoint dirs dynamically")
Cc: stable <stable@vger.kernel.org>
Reviewed-by: Jack Pham <jackp@codeaurora.org>
Signed-off-by: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
Link: https://lore.kernel.org/r/01fafb5b2d8335e98e6eadbac61fc796bdf3ec1a.1623948457.git.Minas.Harutyunyan@synopsys.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Minas Harutyunyan authored and gregkh committed Jul 14, 2021
1 parent 3808a17 commit 35c09ee
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/usb/dwc3/core.c
Expand Up @@ -1605,17 +1605,18 @@ static int dwc3_probe(struct platform_device *pdev)
}

dwc3_check_params(dwc);
dwc3_debugfs_init(dwc);

ret = dwc3_core_init_mode(dwc);
if (ret)
goto err5;

dwc3_debugfs_init(dwc);
pm_runtime_put(dev);

return 0;

err5:
dwc3_debugfs_exit(dwc);
dwc3_event_buffers_cleanup(dwc);

usb_phy_shutdown(dwc->usb2_phy);
Expand Down

0 comments on commit 35c09ee

Please sign in to comment.