Skip to content

Commit

Permalink
eeprom: idt_89hpesx: Restore printing the unsupported fwnode name
Browse files Browse the repository at this point in the history
[ Upstream commit e0db3de ]

When iterating over child firmware nodes restore printing the name of ones
that are not supported.

While at it, refactor loop body to clearly show that we stop at the first match.

Fixes: db15d73 ("eeprom: idt_89hpesx: Support both ACPI and OF probing")
Cc: Huy Duong <qhuyduong@hotmail.com>
Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20210607221757.81465-2-andy.shevchenko@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
andy-shev authored and gregkh committed Jul 14, 2021
1 parent fc8ab06 commit 36f6070
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions drivers/misc/eeprom/idt_89hpesx.c
Original file line number Diff line number Diff line change
Expand Up @@ -1126,11 +1126,10 @@ static void idt_get_fw_data(struct idt_89hpesx_dev *pdev)

device_for_each_child_node(dev, fwnode) {
ee_id = idt_ee_match_id(fwnode);
if (!ee_id) {
dev_warn(dev, "Skip unsupported EEPROM device");
continue;
} else
if (ee_id)
break;

dev_warn(dev, "Skip unsupported EEPROM device %pfw\n", fwnode);
}

/* If there is no fwnode EEPROM device, then set zero size */
Expand Down

0 comments on commit 36f6070

Please sign in to comment.