Skip to content

Commit

Permalink
ARM: dts: sun7i: bananapi: Enable RGMII RX/TX delay on Ethernet PHY
Browse files Browse the repository at this point in the history
[ Upstream commit 8c9cb40 ]

The Ethernet PHY on the Bananapi M1 has the RX and TX delays enabled on
the PHY, using pull-ups on the RXDLY and TXDLY pins.

Fix the phy-mode description to correct reflect this so that the
implementation doesn't reconfigure the delays incorrectly. This
happened with commit bbc4d71 ("net: phy: realtek: fix rtl8211e
rx/tx delay config").

Fixes: 8a5b272 ("ARM: dts: sun7i: Add Banana Pi board")
Signed-off-by: Pablo Greco <pgreco@centosproject.org>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://lore.kernel.org/r/1604326600-39544-1-git-send-email-pgreco@centosproject.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Pablo Greco authored and gregkh committed Dec 30, 2020
1 parent 19d1c76 commit 3890339
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/arm/boot/dts/sun7i-a20-bananapi.dts
Expand Up @@ -132,7 +132,7 @@
pinctrl-names = "default";
pinctrl-0 = <&gmac_rgmii_pins>;
phy-handle = <&phy1>;
phy-mode = "rgmii";
phy-mode = "rgmii-id";
phy-supply = <&reg_gmac_3v3>;
status = "okay";
};
Expand Down

0 comments on commit 3890339

Please sign in to comment.