Skip to content

Commit

Permalink
i2c: Delete error messages for failed memory allocations
Browse files Browse the repository at this point in the history
[ Upstream commit 6b3b21a ]

These issues were detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Stable-dep-of: 05f933d ("i2c: nomadik: Remove a useless call in the remove function")
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
elfring authored and gregkh committed Aug 3, 2023
1 parent 7b7291a commit 38a8983
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 8 deletions.
4 changes: 1 addition & 3 deletions drivers/i2c/busses/i2c-ibm_iic.c
Original file line number Diff line number Diff line change
Expand Up @@ -694,10 +694,8 @@ static int iic_probe(struct platform_device *ofdev)
int ret;

dev = kzalloc(sizeof(*dev), GFP_KERNEL);
if (!dev) {
dev_err(&ofdev->dev, "failed to allocate device data\n");
if (!dev)
return -ENOMEM;
}

platform_set_drvdata(ofdev, dev);

Expand Down
1 change: 0 additions & 1 deletion drivers/i2c/busses/i2c-nomadik.c
Original file line number Diff line number Diff line change
Expand Up @@ -972,7 +972,6 @@ static int nmk_i2c_probe(struct amba_device *adev, const struct amba_id *id)

dev = devm_kzalloc(&adev->dev, sizeof(struct nmk_i2c_dev), GFP_KERNEL);
if (!dev) {
dev_err(&adev->dev, "cannot allocate memory\n");
ret = -ENOMEM;
goto err_no_mem;
}
Expand Down
1 change: 0 additions & 1 deletion drivers/i2c/busses/i2c-sh7760.c
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,6 @@ static int sh7760_i2c_probe(struct platform_device *pdev)

id = kzalloc(sizeof(struct cami2c), GFP_KERNEL);
if (!id) {
dev_err(&pdev->dev, "no mem for private data\n");
ret = -ENOMEM;
goto out0;
}
Expand Down
4 changes: 1 addition & 3 deletions drivers/i2c/busses/i2c-tiny-usb.c
Original file line number Diff line number Diff line change
Expand Up @@ -226,10 +226,8 @@ static int i2c_tiny_usb_probe(struct usb_interface *interface,

/* allocate memory for our device state and initialize it */
dev = kzalloc(sizeof(*dev), GFP_KERNEL);
if (dev == NULL) {
dev_err(&interface->dev, "Out of memory\n");
if (!dev)
goto error;
}

dev->usb_dev = usb_get_dev(interface_to_usbdev(interface));
dev->interface = interface;
Expand Down

0 comments on commit 38a8983

Please sign in to comment.