Skip to content

Commit

Permalink
thermal/drivers/imx_sc_thermal: Fix refcount leak in imx_sc_thermal_p…
Browse files Browse the repository at this point in the history
…robe

[ Upstream commit 09700c5 ]

of_find_node_by_name() returns a node pointer with refcount
incremented, we should use of_node_put() on it when done.
Add missing of_node_put() to avoid refcount leak.

Fixes: e20db70 ("thermal: imx_sc: add i.MX system controller thermal support")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220517055121.18092-1-linmq006@gmail.com
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Yuuoniy authored and gregkh committed Jun 9, 2022
1 parent 21ccc58 commit 3ade442
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions drivers/thermal/imx_sc_thermal.c
Expand Up @@ -94,8 +94,8 @@ static int imx_sc_thermal_probe(struct platform_device *pdev)
sensor = devm_kzalloc(&pdev->dev, sizeof(*sensor), GFP_KERNEL);
if (!sensor) {
of_node_put(child);
of_node_put(sensor_np);
return -ENOMEM;
ret = -ENOMEM;
goto put_node;
}

ret = thermal_zone_of_get_sensor_id(child,
Expand Down Expand Up @@ -124,7 +124,9 @@ static int imx_sc_thermal_probe(struct platform_device *pdev)
dev_warn(&pdev->dev, "failed to add hwmon sysfs attributes\n");
}

put_node:
of_node_put(sensor_np);
of_node_put(np);

return ret;
}
Expand Down

0 comments on commit 3ade442

Please sign in to comment.