Skip to content

Commit

Permalink
phy: renesas: rcar-gen3-usb2: disable runtime pm in case of failure
Browse files Browse the repository at this point in the history
[ Upstream commit 51e339d ]

pm_runtime_enable() will decrease power disable depth. Thus a pairing
increment is needed on the error handling path to keep it balanced.

Fixes: 5d8042e ("phy: rcar-gen3-usb2: Add support for r8a77470")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Li <wangli74@huawei.com>
Link: https://lore.kernel.org/r/20201126024412.4046845-1-wangli74@huawei.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Wang Li authored and gregkh committed Dec 30, 2020
1 parent 8178c53 commit 3aec054
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions drivers/phy/renesas/phy-rcar-gen3-usb2.c
Expand Up @@ -656,8 +656,10 @@ static int rcar_gen3_phy_usb2_probe(struct platform_device *pdev)
*/
pm_runtime_enable(dev);
phy_usb2_ops = of_device_get_match_data(dev);
if (!phy_usb2_ops)
return -EINVAL;
if (!phy_usb2_ops) {
ret = -EINVAL;
goto error;
}

mutex_init(&channel->lock);
for (i = 0; i < NUM_OF_PHYS; i++) {
Expand Down

0 comments on commit 3aec054

Please sign in to comment.