Skip to content

Commit

Permalink
selftest/bpf: Fix error usage of ASSERT_OK in xdp_adjust_tail.c
Browse files Browse the repository at this point in the history
[ Upstream commit cbc1c99 ]

xdp_adjust_tail.c calls ASSERT_OK() to check the return value of
bpf_prog_test_load(), but the condition is not correct. Fix it.

Fixes: 791cad0 ("bpf: selftests: Get rid of CHECK macro in xdp_adjust_tail.c")
Signed-off-by: Xu Kuohai <xukuohai@huawei.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Acked-by: Martin KaFai Lau <martin.lau@kernel.org>
Link: https://lore.kernel.org/bpf/20221011120108.782373-7-xukuohai@huaweicloud.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Xu Kuohai authored and gregkh committed Dec 31, 2022
1 parent bec359a commit 3c48bbf
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions tools/testing/selftests/bpf/prog_tests/xdp_adjust_tail.c
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ static void test_xdp_adjust_tail_shrink(void)
);

err = bpf_prog_test_load(file, BPF_PROG_TYPE_XDP, &obj, &prog_fd);
if (ASSERT_OK(err, "test_xdp_adjust_tail_shrink"))
if (!ASSERT_OK(err, "test_xdp_adjust_tail_shrink"))
return;

err = bpf_prog_test_run_opts(prog_fd, &topts);
Expand Down Expand Up @@ -53,7 +53,7 @@ static void test_xdp_adjust_tail_grow(void)
);

err = bpf_prog_test_load(file, BPF_PROG_TYPE_XDP, &obj, &prog_fd);
if (ASSERT_OK(err, "test_xdp_adjust_tail_grow"))
if (!ASSERT_OK(err, "test_xdp_adjust_tail_grow"))
return;

err = bpf_prog_test_run_opts(prog_fd, &topts);
Expand Down Expand Up @@ -90,7 +90,7 @@ static void test_xdp_adjust_tail_grow2(void)
);

err = bpf_prog_test_load(file, BPF_PROG_TYPE_XDP, &obj, &prog_fd);
if (ASSERT_OK(err, "test_xdp_adjust_tail_grow"))
if (!ASSERT_OK(err, "test_xdp_adjust_tail_grow"))
return;

/* Test case-64 */
Expand Down

0 comments on commit 3c48bbf

Please sign in to comment.