Skip to content

Commit

Permalink
Revert "drm/i915/bios: Split VBT parsing to global vs. panel specific…
Browse files Browse the repository at this point in the history
… parts"

This reverts commit 2af21ae which is
commit c2fdb42 upstream.

This is part of a series of i915 patches that were backported to 5.19.12
but found to be incomplete and caused problems on many systems so they
are being reverted.

Reported-by: Jerry Ling <jiling@cern.ch>
Reported-by: Hans de Goede <hdegoede@redhat.com>
Cc: Thorsten Leemhuis <regressions@leemhuis.info>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Sasha Levin <sashal@kernel.org>
Link: https://lore.kernel.org/all/55905860-adf9-312c-69cc-491ac8ce1a8b@cern.ch/
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
gregkh committed Oct 4, 2022
1 parent 139d38c commit 3f2631c
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 17 deletions.
26 changes: 11 additions & 15 deletions drivers/gpu/drm/i915/display/intel_bios.c
Expand Up @@ -2969,7 +2969,18 @@ void intel_bios_init(struct drm_i915_private *i915)
/* Grab useful general definitions */
parse_general_features(i915);
parse_general_definitions(i915);
parse_panel_options(i915);
parse_generic_dtd(i915);
parse_lfp_data(i915);
parse_lfp_backlight(i915);
parse_sdvo_panel_data(i915);
parse_driver_features(i915);
parse_panel_driver_features(i915);
parse_power_conservation_features(i915);
parse_edp(i915);
parse_psr(i915);
parse_mipi_config(i915);
parse_mipi_sequence(i915);

/* Depends on child device list */
parse_compression_parameters(i915);
Expand All @@ -2988,21 +2999,6 @@ void intel_bios_init(struct drm_i915_private *i915)
kfree(oprom_vbt);
}

void intel_bios_init_panel(struct drm_i915_private *i915)
{
parse_panel_options(i915);
parse_generic_dtd(i915);
parse_lfp_data(i915);
parse_lfp_backlight(i915);
parse_sdvo_panel_data(i915);
parse_panel_driver_features(i915);
parse_power_conservation_features(i915);
parse_edp(i915);
parse_psr(i915);
parse_mipi_config(i915);
parse_mipi_sequence(i915);
}

/**
* intel_bios_driver_remove - Free any resources allocated by intel_bios_init()
* @i915: i915 device instance
Expand Down
1 change: 0 additions & 1 deletion drivers/gpu/drm/i915/display/intel_bios.h
Expand Up @@ -230,7 +230,6 @@ struct mipi_pps_data {
} __packed;

void intel_bios_init(struct drm_i915_private *dev_priv);
void intel_bios_init_panel(struct drm_i915_private *dev_priv);
void intel_bios_driver_remove(struct drm_i915_private *dev_priv);
bool intel_bios_is_valid_vbt(const void *buf, size_t size);
bool intel_bios_is_tv_present(struct drm_i915_private *dev_priv);
Expand Down
1 change: 0 additions & 1 deletion drivers/gpu/drm/i915/display/intel_display.c
Expand Up @@ -9580,7 +9580,6 @@ int intel_modeset_init_noirq(struct drm_i915_private *i915)
}

intel_bios_init(i915);
intel_bios_init_panel(i915);

ret = intel_vga_register(i915);
if (ret)
Expand Down

0 comments on commit 3f2631c

Please sign in to comment.