Skip to content

Commit

Permalink
USB: serial: keyspan_pda: remove unused variable
Browse files Browse the repository at this point in the history
Remove an unused variable which was mistakingly left by commit
37faf50 ("USB: serial: keyspan_pda: fix write-wakeup
use-after-free") and only removed by a later change.

This is needed to suppress a W=1 warning about the unused variable in
the stable trees that the build bots triggers.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
jhovold authored and gregkh committed Jan 12, 2021
1 parent a4b202c commit 3f47b18
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/usb/serial/keyspan_pda.c
Expand Up @@ -555,10 +555,8 @@ static int keyspan_pda_write(struct tty_struct *tty,
static void keyspan_pda_write_bulk_callback(struct urb *urb)
{
struct usb_serial_port *port = urb->context;
struct keyspan_pda_private *priv;

set_bit(0, &port->write_urbs_free);
priv = usb_get_serial_port_data(port);

/* queue up a wakeup at scheduler time */
usb_serial_port_softint(port);
Expand Down

0 comments on commit 3f47b18

Please sign in to comment.